[WEBCLIENT-136] Date Constraints lost in webclient when executing a query created in workbench Created: 21/Sep/15 Updated: 25/Jan/16 Resolved: 15/Dec/15 |
|
| Status: | Closed |
| Project: | i2b2 Web Client |
| Component/s: | Web Client |
| Affects Version/s: | 1.7.06 |
| Fix Version/s: | 1.7.07 |
| Type: | Bug | Priority: | Major |
| Reporter: | Janice Donahoe | Assignee: | Janice Donahoe |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Affects View/s: |
Query Tool
|
||||||||
| i2b2 Feature/s: |
Constraints - Date
|
||||||||
| i2b2 Sponsored Project/s: |
i2b2 Web Client
|
||||||||
| Affects Database/s: |
All databases
|
||||||||
| Affects Web Browser/s: |
All Web Browsers
|
||||||||
| Reproduction Notes: | This can be reproduced in both the i2b2 demo and test environments.
As the description states the date constraints are in the xml that is returned when the previous query is dropped into the query tool but it is not updating the constraints in the Date Constraint window. As a result when the query is run there are no date constraints defined in the new query. STEPS TO REPRODUCE: 1. Log into the Workbench. 2. Drag a concept to the Query Tool and add a date constraint. 3. Run the query. 4. Log into the Web Client. 5. In Previous Queries, identify the query you just ran in the Workbench. 6. Drag it to the Query Tool. 7. Notice the "Date" button does not have an underline, indicating it has a date constraint. 8. Open the Date Constraint window and notice the dates defined on the original query do not appear. 9. Click on Cancel to close the Date Constraint window. 10. Look at the XML message received when the query was dropped in the Query Tool, you will notice the correct date constraints are included in the message. 11. Run the query. 12. Look at the request xml that was sent when running the query and notice there are no date constraints defined in the xml. |
||||||||
| Testing Notes: | TEST STATUS: Completed
COMPLETION DATE: 12/15/2015 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Test Date: 12/15/2015 Build Number: 1.7.07.0005 Test Status: Completed (Passed Testing) Clients Tested : i2b2 Web Client i2b2 Workbench Environments Tested : Browsers: Chrome, Firefox, Internet Explorer, and Safari Databases: Not applicable for this test Client OS: Windows and Macintosh (Release 1.7.06) Test Comments: Tested with the latest Web Client build and it appears to be working correctly. Queries with date constraints that were initially run in the Workbench will now run in Web Client with no problem. ISSUES FOUND: A issue was found but it is related to a new feature that adds date constraints to the item level ( |
||||||||
| Participant/s: | |||||||||
| Build Number (Fixed): | 1.7.07.0005 | ||||||||
| Description |
|
When you run a query in the workbench with a date constraint, these constraints are not maintained when you use the query in the Web Client. The date constraints do appear in the xml received when the item is dropped but they do not appear in the panel next to the item name. If you run the query it will not have the date constraints in the sent xml. Also if you go into the date constraint window the dates will not appear.
IMPORTANT: This issue is also a problem in the Workbench. |
| Comments |
| Comment by Nich [ 07/Dec/15 ] |
|
The webclient and workbench are handling dates differently in the request XML for dates.
The webclient constructs the following XML: <panel> ... <panel_date_from>1979-12-01T00:00:00.000-05:00</panel_date_from> <panel_date_to>2005-12-07T00:00:00.000-05:00</panel_date_to> The workbench constructs the following XML: <panel> ... <item> <constrain_by_date> <date_from>1979-12-01T00:00:00-05:00</date_from> <date_to>2005-12-07T00:00:00-05:00</date_to> </constrain_by_date> For previous queries, the webclient only reads <panel><panel_date_from>, and the workbench only reads <panel><item><constrain_by_date><date_from> |
| Comment by Nich [ 09/Dec/15 ] |
| Fix will be deferred to 1.7.08 since Date Constraints will be reworked in web client. |
| Comment by Nich [ 09/Dec/15 ] |
| I was able to fix this with backwards-support in 1.7.07. Moving this back to resolved in 1.7.07. |
| Comment by Janice Donahoe [ 25/Jan/16 ] |
|
On 01/22/2016, the 1.7.07 Release was made available at the following locations.
https://www.i2b2.org/software/ - zip files for release 1.7.07 are available on this site. This includes both the code and documentation. https://github.com/i2b2 - source code has been tagged with v1.7.07. |