Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.7.04
    • Fix Version/s: 1.7.05
    • Component/s: Ontology Cell
    • Labels:
      None
    • Affects View/s:
      Find Terms, Navigate Terms, Query Tool, Workplace
    • i2b2 Feature/s:
      Queries
    • i2b2 Sponsored Project/s:
      i2b2 Web Client
    • Affects Database/s:
      Oracle
    • Affects Web Browser/s:
      All Web Browsers
    • Reproduction Notes:
      Hide
      This can be reproduced in the i2b2 development environment. Containers can be dragged from Navigate and Find Terms and dropped into the Query Tool or Workplace.

      The problem also extends to Modifier containers.

      Both types of containers typically do not have a base code associated to them, which will cause a number of errors if used to run a query in the i2b2. Therefore users should not be able to drag / drop any containers or modifier containers between i2b2 views.

      The C_VISUALATTRIBUTE column is used to determine the type of term and how it is displayed in the clients. The first character defines the type (container, folder, leaf, modifier, multi, etc.) and can be used to determine if an item can be dragged. The following are the first characters for both containers and modifier containers.

      Container = C
      Modifier Container = O
      Show
      This can be reproduced in the i2b2 development environment. Containers can be dragged from Navigate and Find Terms and dropped into the Query Tool or Workplace. The problem also extends to Modifier containers. Both types of containers typically do not have a base code associated to them, which will cause a number of errors if used to run a query in the i2b2. Therefore users should not be able to drag / drop any containers or modifier containers between i2b2 views. The C_VISUALATTRIBUTE column is used to determine the type of term and how it is displayed in the clients. The first character defines the type (container, folder, leaf, modifier, multi, etc.) and can be used to determine if an item can be dragged. The following are the first characters for both containers and modifier containers. Container = C Modifier Container = O
    • Testing Notes:
      Hide
      Test Date: 04/16/2015
      Build Number:
      Test Status: Passed

      Test Comments:
      Tested with the latest web client build and it appears to be working correctly. Verified containers, including modifier containers can not be dragged from Navigate or Find Terms.

      Clients Tested :
           i2b2 Web Client

      Environments Tested :
           Browsers: Chrome, Firefox, Internet Explorer, Safari
           Databases: Not applicable for this test
           Client OS: Macintosh, Windows
      Show
      Test Date: 04/16/2015 Build Number: Test Status: Passed Test Comments: Tested with the latest web client build and it appears to be working correctly. Verified containers, including modifier containers can not be dragged from Navigate or Find Terms. Clients Tested :      i2b2 Web Client Environments Tested :      Browsers: Chrome, Firefox, Internet Explorer, Safari      Databases: Not applicable for this test      Client OS: Macintosh, Windows

      Description

      Within the Ontology navigation containers are now draggable into queries. Based off of how these are built, they may not actually be useable and return failed queries or errors. If intended to be draggable by default, this should be noted somewhere as it was previously not allowed.

      Tracked to a commented line in /js-i2b2/cells/ONT/ONT_sdx_CONCPT.js:

      i2b2.sdx.TypeControllers.CONCPT.RenderHTML= function(sdxData, options, targetDiv) {
      ....
      if (!Object.isUndefined(options.dragdrop)) {
      // NOTE TO SELF: should attachment of node dragdrop controller be handled by the SDX system as well?
      // This would ensure removal of the onmouseover call in a cross-browser way
      var sDD = ' onmouseover="' + options.dragdrop + '(\''+ targetDiv.id +'\',\'' + id + '\')" ';
      } else {
      var sDD = '';
      }

      // process allowing children to be viewed
      var bCanExp = false;
      if (sdxData.origData.hasChildren.substring(1,0) === "C"){
      // render as category
      icon = 'root';
      ----> //sDD = ''; //This line dictates if the containers are draggable
      sIG = ' isGroup="Y"';
      bCanExp = true;
      }
      ......

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Git Source Code