Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 1.7.04
-
Fix Version/s: 1.7.05
-
Component/s: Ontology Cell
-
Labels:None
-
Affects View/s:Find Terms, Navigate Terms, Query Tool, Workplace
-
i2b2 Feature/s:Queries
-
i2b2 Sponsored Project/s:i2b2 Web Client
-
Affects Database/s:Oracle
-
Affects Web Browser/s:All Web Browsers
-
Reproduction Notes:
-
Testing Notes:
Description
Within the Ontology navigation containers are now draggable into queries. Based off of how these are built, they may not actually be useable and return failed queries or errors. If intended to be draggable by default, this should be noted somewhere as it was previously not allowed.
Tracked to a commented line in /js-i2b2/cells/ONT/ONT_sdx_CONCPT.js:
i2b2.sdx.TypeControllers.CONCPT.RenderHTML= function(sdxData, options, targetDiv) {
....
if (!Object.isUndefined(options.dragdrop)) {
// NOTE TO SELF: should attachment of node dragdrop controller be handled by the SDX system as well?
// This would ensure removal of the onmouseover call in a cross-browser way
var sDD = ' onmouseover="' + options.dragdrop + '(\''+ targetDiv.id +'\',\'' + id + '\')" ';
} else {
var sDD = '';
}
// process allowing children to be viewed
var bCanExp = false;
if (sdxData.origData.hasChildren.substring(1,0) === "C"){
// render as category
icon = 'root';
----> //sDD = ''; //This line dictates if the containers are draggable
sIG = ' isGroup="Y"';
bCanExp = true;
}
......
Tracked to a commented line in /js-i2b2/cells/ONT/ONT_sdx_CONCPT.js:
i2b2.sdx.TypeControllers.CONCPT.RenderHTML= function(sdxData, options, targetDiv) {
....
if (!Object.isUndefined(options.dragdrop)) {
// NOTE TO SELF: should attachment of node dragdrop controller be handled by the SDX system as well?
// This would ensure removal of the onmouseover call in a cross-browser way
var sDD = ' onmouseover="' + options.dragdrop + '(\''+ targetDiv.id +'\',\'' + id + '\')" ';
} else {
var sDD = '';
}
// process allowing children to be viewed
var bCanExp = false;
if (sdxData.origData.hasChildren.substring(1,0) === "C"){
// render as category
icon = 'root';
----> //sDD = ''; //This line dictates if the containers are draggable
sIG = ' isGroup="Y"';
bCanExp = true;
}
......
Attachments
Issue Links
- is duplicated by
-
WEBCLIENT-111 Containers can be dragged into the Query Window & queried
-
- Closed
-