Uploaded image for project: 'i2b2 Web Client'
  1. i2b2 Web Client
  2. WEBCLIENT-217

Integers & fractional numbers can be entered for Max Time to Wait in Query Tool

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.7.09c
    • None
    • None

    Description

      In the Query Tool, users have the ability to define the "Maximum Time to Wait for XML Response..." from the server before the query will timeout. Currently, users can enter in negative numbers & fractions including alphanumeric. The user is able to save the invalid entries without any warning.

      Resolution:
      Only allow whole numbers to be entered. If anything other than a whole number is entered present the user with a warning telling them that they need to enter a whole number.


      Git Source Code
      commit f3a6d5408558a18837774c97c55fb6adf5538d2a
      commit d3ae8f6f33ec0f153c72c7b69c032cd87fcbe9ba

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          mem61 Mike Mendis created issue -
          mem61 Mike Mendis made changes -
          Field Original Value New Value
          Assignee Mike Mendis [ mem61 ]
          mem61 Mike Mendis made changes -
          Status New [ 10000 ] Open [ 1 ]
          mem61 Mike Mendis made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          mem61 Mike Mendis made changes -
          Assignee Mike Mendis [ mem61 ] Janice Donahoe [ jmd86 ]
          Status In Progress [ 3 ] Ready to Test [ 10001 ]
          jmd86 Janice Donahoe made changes -
          Fix Version/s 1.7.09c [ 10800 ]
          jmd86 Janice Donahoe made changes -
          Status Ready to Test [ 10001 ] Testing [ 10002 ]
          jmd86 Janice Donahoe added a comment -
          The wording in the new error message needs to be rewritten to remove some redundancy. For instance, the whole numbers can only be positive so we do not need to state that in the message. The options dialog already tells the user the value entered is in seconds. Also, "query timeout period" is not consistent with the wording in the options dialog and may provide a source of confusion for the users.

          Current wording:
                 " Please note that the query timeout period must be a plain positive whole number (in seconds). "


          New wording:
                  " Please enter a whole number for the maximum time to wait. "

          jmd86 Janice Donahoe added a comment - The wording in the new error message needs to be rewritten to remove some redundancy. For instance, the whole numbers can only be positive so we do not need to state that in the message. The options dialog already tells the user the value entered is in seconds. Also, "query timeout period" is not consistent with the wording in the options dialog and may provide a source of confusion for the users. Current wording:        " Please note that the query timeout period must be a plain positive whole number (in seconds). " New wording:         " Please enter a whole number for the maximum time to wait. "
          jmd86 Janice Donahoe made changes -
          Description When setting the timeout on a query in the query tool, a user is about to put in a NaN & fractional number. The webclient is validate before sending to the CRC and the message will be as follows: Please note that the query timeout period must be a plain positive whole number (in seconds).
          		When setting the timeout on a query in the query tool, a user is about to put in a 'a' & fractional number. The webclient is validate before sending to the CRC and the message will be as follows: Please note that the query timeout period must be a plain positive whole number (in seconds).
          jmd86 Janice Donahoe made changes -
          Summary Query Timeout Integers & fractional numbers can be entered for Max Time to Wait in Query Tool
          jmd86 Janice Donahoe made changes -
          Description When setting the timeout on a query in the query tool, a user is about to put in a 'a' & fractional number. The webclient is validate before sending to the CRC and the message will be as follows: Please note that the query timeout period must be a plain positive whole number (in seconds).
          		In the Query Tool, users have the ability to define the "Maximum Time to Wait for XML Response..." from the server before the query will timeout. Currently, users can enter in negative numbers & fractions including alphanumeric. The user is able to save the invalid entries without any warning.

          Resolution:
          Only allow whole numbers to be entered. If anything other than a whole number is entered present the user with a warning telling them that they need to enter a whole number.


          Git Source Code
          commit f3a6d5408558a18837774c97c55fb6adf5538d2a
          commit d3ae8f6f33ec0f153c72c7b69c032cd87fcbe9ba
          jmd86 Janice Donahoe made changes -
          Assignee Janice Donahoe [ jmd86 ] Mike Mendis [ mem61 ]
          jmd86 Janice Donahoe made changes -
          Status Testing [ 10002 ] Reopened [ 4 ]
          jmd86 Janice Donahoe added a comment -
          This was fixed and included in the 1.7.09c release.
          jmd86 Janice Donahoe added a comment - This was fixed and included in the 1.7.09c release.
          jmd86 Janice Donahoe made changes -
          Resolution Fixed [ 1 ]
          Status Reopened [ 4 ] Resolved [ 5 ]
          jmd86 Janice Donahoe made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

          People

            mem61 Mike Mendis
            mem61 Mike Mendis
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: