[WEBCLIENT-217] Integers & fractional numbers can be entered for Max Time to Wait in Query Tool Created: 01/Dec/17 Updated: 25/Jan/18 Resolved: 25/Jan/18 |
|
| Status: | Closed |
| Project: | i2b2 Web Client |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.7.09c |
| Type: | Bug | Priority: | Major |
| Reporter: | Mike Mendis | Assignee: | Mike Mendis |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Participant/s: |
| Description |
|
In the Query Tool, users have the ability to define the "Maximum Time to Wait for XML Response..." from the server before the query will timeout. Currently, users can enter in negative numbers & fractions including alphanumeric. The user is able to save the invalid entries without any warning.
Resolution: Only allow whole numbers to be entered. If anything other than a whole number is entered present the user with a warning telling them that they need to enter a whole number. Git Source Code commit f3a6d5408558a18837774c97c55fb6adf5538d2a commit d3ae8f6f33ec0f153c72c7b69c032cd87fcbe9ba |
| Comments |
| Comment by Janice Donahoe [ 06/Dec/17 ] |
|
The wording in the new error message needs to be rewritten to remove some redundancy. For instance, the whole numbers can only be positive so we do not need to state that in the message. The options dialog already tells the user the value entered is in seconds. Also, "query timeout period" is not consistent with the wording in the options dialog and may provide a source of confusion for the users.
Current wording: " Please note that the query timeout period must be a plain positive whole number (in seconds). " New wording: " Please enter a whole number for the maximum time to wait. " |
| Comment by Janice Donahoe [ 25/Jan/18 ] |
| This was fixed and included in the 1.7.09c release. |