Uploaded image for project: 'i2b2 Core Software'
  1. i2b2 Core Software
  2. CORE-369

inconsistent naming of column PM_HIVE_PARAMS.domain_id

Details

    • Bug
    • Status: New
    • Minor
    • Resolution: Unresolved
    • None
    • TBD
    • None
    • None

    Description

      The column PM_HIVE_PARAMS.domain_id is not the same as the column PM_HIVE_DATA.domain_id ...
      It should be PM_HIVE_PARAMS.domain_name, so that it links to PM_HIVE_DATA.domain_name.

      This bug creates a problem when using global parameters in the class ServiceHandler.java, where domainId is referenced to the DomainName.
      (Or another solution is to change the reference of domainId to the real domain_id instead of the domain_name...)

      {code}
      public String execute() throws I2B2Exception{
         ...
         while (it.hasNext()) {
            ...
            domainId = cType.getDomainName();
         }
         ...
         try {
            ...
            //Get any remaining params from the environment
      for( it=pmDb.getEnvironmentData(domainId).iterator();it.hasNext();){
      HiveParamData hivedata =(HiveParamData)it.next();
      params.put(hivedata.getName(), hivedata.getValue());
      }
            ...
         }
         ...
      }

      Attachments

        Activity

          tseto Tina Seto added a comment -

          Adding a related bug:

          In the latest i2b2 1.7.04 release, there is a bug in edu.harvard.i2b2.pm.delegate.ServicesHandler.java line 268.

          > if (!cType.getDomainName().equalsIgnoreCase(rmt.getDomain().toUpperCase()))

          It should compare the domain ids, not the domain name to the domain id.

          The workaround is to set your domain_name to be the same as the domain_id in PM_HIVE_DATA. 
          tseto Tina Seto added a comment - Adding a related bug: In the latest i2b2 1.7.04 release, there is a bug in edu.harvard.i2b2.pm.delegate.ServicesHandler.java line 268. > if (!cType.getDomainName().equalsIgnoreCase(rmt.getDomain().toUpperCase())) It should compare the domain ids, not the domain name to the domain id. The workaround is to set your domain_name to be the same as the domain_id in PM_HIVE_DATA. 
          Needs to be reviewed further. This change will affect many areas of the code and potentially many users and may have many implications.
          jmd86 Janice Donahoe added a comment - Needs to be reviewed further. This change will affect many areas of the code and potentially many users and may have many implications.

          People

            mem61 Mike Mendis
            koen.janssens@uza.be Koen Janssens
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated: