[WEBCLIENT-122] Clicking on Login button with missing or invalid username/password is not displaying the right error message Created: 01/Jun/15 Updated: 25/Jan/16 Resolved: 02/Dec/15 |
|
Status: | Closed |
Project: | i2b2 Web Client |
Component/s: | None |
Affects Version/s: | None |
Fix Version/s: | 1.7.07 |
Type: | Bug | Priority: | Major |
Reporter: | Reeta Metta | Assignee: | Janice Donahoe |
Resolution: | Fixed | Votes: | 0 |
Labels: | None | ||
Remaining Estimate: | Not Specified | ||
Time Spent: | Not Specified | ||
Original Estimate: | Not Specified |
Attachments: |
![]() ![]() |
Participant/s: |
Description |
navigate to https://www.i2b2.org/webclient/ enter only username without a password or invalid password click on "Login" button Message should be displayed that user credentials are missing or invalid. Message is displayed as "Error: is not assoicated with this domain i2b2demo. Please check i2b2workbech.properties file" |
Comments |
Comment by Janice Donahoe [ 01/Jun/15 ] |
Not able to reproduce this on the i2b2 demo site (https://www.i2b2.org/webclient/). When I enter the wrong password I receive an error message that says:
ERROR: Current password is incorrect See attached screen print (loginMessage.png) |
Comment by Janice Donahoe [ 04/Jun/15 ] |
I am re-opening this issue because the reported problem will occur when the following criteria is met.
1. Leave both the username AND password fields blank. 2. Enter the wrong username AND leave the password field blank. The reason the second scenario worked correctly for me in the past is because you can only reproduce it if you have not received any other errors. In other words if you enter the wrong username and a password you will receive the appropriate error message. (ERROR: Username does not exist). Once you go back and enter the wrong username and leave the password field blank the correct error message will appear. STEPS TO REPRODUCE: 1. At the Web Client Login page, make sure the username and password field is blank. 2. Click on the Login button and notice an error message will appear saying: ERROR: is not associated to this domain i2b2demo. Please check the i2b2workbench.properties file. 3. Go back to the username and enter the wrong username. 4. Leave the password field blank. 5. Click on the Login button and notice the wrong error message will appear. SUGGESTED SOLUTION: Overall, the best solution might be to make the Login button inactive until text has been entered at the username and password fields. Once text is entered the Login button becomes active. This will prevent the Web Client from sending empty strings that the PM cell doesn’t like. Aside from the above solution, the error message needs to clearly define the issue to the user. Scenario 1: Username field is empty. Error message says: “ERROR: Please enter a username.” Scenario 2: Text is entered at the Username field but the Password field is empty. Error message says: “ERROR: Please enter a password.” Scenario 3: Username and Password fields are empty. Error message says: “ERROR: Please enter a username and password.” Scenario 4: Unknown username entered and a password is entered. Error message says: “ERROR: Username does not exist.” Scenario 5: Valid username entered and the wrong password is entered. Error message says: “ERROR: Current password is incorrect.” NOTE: Scenario #4 and 5 are currently working correctly. When this fix is applied these scenarios will need to be re-tested to verify they are still working correctly. |
Comment by Reeta Metta [ 02/Dec/15 ] |
Tested in windows ie, chrome, firefox,
and mac safari, chrome and firefox. Working as expected |
Comment by Janice Donahoe [ 25/Jan/16 ] |
On 01/22/2016, the 1.7.07 Release was made available at the following locations.
https://www.i2b2.org/software/ - zip files for release 1.7.07 are available on this site. This includes both the code and documentation. https://github.com/i2b2 - source code has been tagged with v1.7.07. |