Details
-
Bug
-
Status: Closed
-
Major
-
Resolution: Fixed
-
None
-
None
-
None
Description
There are several places in the CRC cell surrounding the setvalue javascript that reference the statusText which were failing on successful responses because the statusText was empty on servers returning http/2 protocols.
Change theresponse status check from "OK" to 200 instead for lab value pop up handling
Github commit:
2 2 changes: 1 addition & 1 deletion js-i2b2/cells/CRC/ModLabValues/CRC_view_ENUM.js
@@ -32,7 +32,7 @@ i2b2.CRC.view.ENUM = {
32 32 var url = "js-i2b2/cells/CRC/ModLabValues/CRC_view_ENUM.html";
33 33 var response = new Ajax.Request(url, {method: 'get', asynchronous: false});
34 34 console.dir(response);
35 - if (response.transport.statusText=="OK") {
35 + if (response.transport.status == 200) {
36 36 thisHTML = response.transport.responseText;
37 37 } else {
38 38 alert('A problem was encounter while loading the html for the value type!');
Change theresponse status check from "OK" to 200 instead for lab value pop up handling
Github commit:
2 2 changes: 1 addition & 1 deletion js-i2b2/cells/CRC/ModLabValues/CRC_view_ENUM.js
@@ -32,7 +32,7 @@ i2b2.CRC.view.ENUM = {
32 32 var url = "js-i2b2/cells/CRC/ModLabValues/CRC_view_ENUM.html";
33 33 var response = new Ajax.Request(url, {method: 'get', asynchronous: false});
34 34 console.dir(response);
35 - if (response.transport.statusText=="OK") {
35 + if (response.transport.status == 200) {
36 36 thisHTML = response.transport.responseText;
37 37 } else {
38 38 alert('A problem was encounter while loading the html for the value type!');
Attachments
Activity
Field | Original Value | New Value |
---|---|---|
Fix Version/s | 1.7.13 [ 11002 ] |
Assignee | Jeffrey Klann [ jklann ] |
Resolution | Fixed [ 1 ] |
Status | New [ 10000 ] | Open [ 1 ] |
Status | Open [ 1 ] | In Progress [ 3 ] |
Status | In Progress [ 3 ] | Resolved [ 5 ] |
Resolution | Fixed [ 1 ] | |
Status | Resolved [ 5 ] | Reopened [ 4 ] |
Resolution | Fixed [ 1 ] | |
Status | Reopened [ 4 ] | Resolved [ 5 ] |
Assignee | Jeffrey Klann [ jklann ] | Reeta Metta [ rm302 ] |
Assignee | Reeta Metta [ rm302 ] | Jeffrey Klann [ jklann ] |
Resolution | Fixed [ 1 ] | |
Status | Resolved [ 5 ] | Reopened [ 4 ] |
Status | Reopened [ 4 ] | In Progress [ 3 ] |
Status | In Progress [ 3 ] | Ready to Test [ 10001 ] |
Assignee | Jeffrey Klann [ jklann ] | Reeta Metta [ rm302 ] |
Resolution | Fixed [ 1 ] | |
Status | Ready to Test [ 10001 ] | Resolved [ 5 ] |
Status | Resolved [ 5 ] | Closed [ 6 ] |