Uploaded image for project: 'i2b2 Web Client'
  1. i2b2 Web Client
  2. WEBCLIENT-291

Date constraints popup OK button disabled, maintains new date if canceled

Details

    • Improvement
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • 1.7.08, 1.7.09, 1.7.10, 1.7.11, 1.7.12
    • TBD, 1.7.14
    • None
    • None
    • Chrome

    Description

      Drag over existing query with a date constraint group
      Click Dates link on group
      Alter either date
      Attempt to click OK
      Nothing happens
      Click Cancel
      Create new group so the date constraint group goes out of view
      Page back to date constraint group
      Group shows new date you entered but canceled

      Attachments

        Activity

          nich Nich added a comment -
          Hi Brian,

          What version of the web client were you using that this issue occurred in?

          Thanks,
          Nich
          nich Nich added a comment - Hi Brian, What version of the web client were you using that this issue occurred in? Thanks, Nich
          We are on 1.7.08a

          Though I just tried to recreate it and it appears there's some nuance to when it hits.
          One variation I am seeing now though is a date constraint on the first group of two groups, where they're marked as same financial encounter. In this case when you drag it back over, the date constraint is there next to the concept code, but not in the Dates link.
          bostasie Brian Ostasiewski added a comment - We are on 1.7.08a Though I just tried to recreate it and it appears there's some nuance to when it hits. One variation I am seeing now though is a date constraint on the first group of two groups, where they're marked as same financial encounter. In this case when you drag it back over, the date constraint is there next to the concept code, but not in the Dates link.
          nich Nich added a comment -
          Hi Brian,

          I think I understand now. This was a re-working of the dates in the web client. Basically, to conform with how dates have always worked in the workbench (and they were supposed to work in the web client), the concept is that date constraints are only applied to individual items (concepts) and not the panels. When you set a date on a panel, it is essentially a "shortcut" which applies that date constraint to every item in the panel.

          This change allows for items in the same panel to have different dates, that is, you don't actually need to use the date "shortcut" in the panel, you can apply different dates to an item by right-clicking it. Additionally, when you drag over a previous query containing dates, there's no good way to tell that the query was run using the panel shortcut, etc. which is why you won't necessarily see the "Date" text underlined.

          Hope this helps.

          Thanks,
          Nich
          nich Nich added a comment - Hi Brian, I think I understand now. This was a re-working of the dates in the web client. Basically, to conform with how dates have always worked in the workbench (and they were supposed to work in the web client), the concept is that date constraints are only applied to individual items (concepts) and not the panels. When you set a date on a panel, it is essentially a "shortcut" which applies that date constraint to every item in the panel. This change allows for items in the same panel to have different dates, that is, you don't actually need to use the date "shortcut" in the panel, you can apply different dates to an item by right-clicking it. Additionally, when you drag over a previous query containing dates, there's no good way to tell that the query was run using the panel shortcut, etc. which is why you won't necessarily see the "Date" text underlined. Hope this helps. Thanks, Nich
          This is working as designed. A possible future improvement would be to detect if all date constraints are the same in a panel and re-highlight the date button. Deferring to 1.7.13.
          jklann Jeffrey Klann added a comment - This is working as designed. A possible future improvement would be to detect if all date constraints are the same in a panel and re-highlight the date button. Deferring to 1.7.13.

          People

            jklann Jeffrey Klann
            bostasie Brian Ostasiewski
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated: