Testing Notes:
Tested with the latest build and it appears to be working correctly. Tested the xml message using Advanced Rest Client in google chrome. The PDO was returned without any errors.
Consider a GetPDOFromInputList request like this:
<message_body>
<ns3:pdoheader>
<patient_set_limit>0</patient_set_limit>
<estimated_time>180000</estimated_time>
<request_type>getPDO_fromInputList</request_type>
</ns3:pdoheader>
<ns3:request xsi:type="ns3:GetPDOFromInputList_requestType" xmlns:xsi="
http://www.w3.org/2001/XMLSchema-instance ">
<input_list>
<patient_list min="0" max="0">
<patient_set_coll_id>3</patient_set_coll_id>
</patient_list>
</input_list>
<filter_list>
<panel name="The panel name">
<panel_number>1</panel_number>
<panel_accuracy_scale>1</panel_accuracy_scale>
<invert>0</invert>
<item>
<hlevel>2</hlevel>
<item_key>\\i2b2\i2b2\Diagnoses\Circulatory system (390-459)\</item_key>
<dim_tablename>concept_dimension</dim_tablename>
<dim_dimcode>\i2b2\Diagnoses\Circulatory system (390-459)\</dim_dimcode>
<item_is_synonym>false</item_is_synonym>
</item>
</panel>
</filter_list>
<output_option names="asattributes">
<observation_set techdata="true" onlykeys="false" blob="false"/>
<patient_set techdata="true" select="using_input_list" onlykeys="false"/>
<event_set techdata="true" select="using_filter_list" onlykeys="false"/>
<observer_set_using_filter_list techdata="true" select="using_filter_list" onlykeys="false"/>
<concept_set_using_filter_list select="using_filter_list" onlykeys="false"/>
<modifier_set_using_filter_list techdata="true" select="using_filter_list" onlykeys="false"/>
</output_option>
</ns3:request>
</message_body>
The key point is either that it has panels / items in its filter list or some output option (I don't really know). This will cause following exception:
"java.sql.SQLSyntaxErrorException: ORA-00928: missing SELECT keyword" in class edu.harvard.i2b2.crc.dao.pdo.TablePdoQueryConceptDao.
I think I found the bug in line 108 ff. If you don't use postgre SQL an SQL statement is built like:
INSERT INTO I2B2BASTIPROJECT.GLOBAL_TEMP_FACT_PARAM_TABLE (char_param1) (char_param1)
SELECT ...
This is wrong SQL syntax as (char_param1) appears twice and Oracle expects a SELECT in the second brackets. To fix it, change line 110
insertSql += "(char_param1) select distinct obs_concept_cd from ( "
to
insertSql += "select distinct obs_concept_cd from ( "
I haven't tried this fix with postgre, so please check if it still works with postgre before checking it in.
Janice Donahoe
made changes -
22/May/14 5:58 PM
Field
Original Value
New Value
Workflow
classic default workflow
[ 10247
]
i2b2 Issues
[ 10311
]
Janice Donahoe
made changes -
29/May/14 4:07 PM
Workflow
i2b2 Issues
[ 10311
]
i2b2 Issues Workflow
[ 10445
]
Mike Mendis
made changes -
03/Jun/14 4:11 PM
Status
Open
[ 1
]
In Progress
[ 3
]
Mike Mendis
made changes -
03/Jun/14 4:11 PM
Fix Version/s
1.7.02
[ 10091
]
Assignee
Mike Mendis
[ mem61
]
Janice Donahoe
[ jmd86
]
Status
In Progress
[ 3
]
Ready to Test
[ 10001
]
Janice Donahoe
made changes -
05/Jun/14 6:36 PM
Component/s
CRC Cell
[ 10049
]
Component/s
CRC Cell
[ 10000
]
Fix Version/s
1.7.02
[ 10155
]
Fix Version/s
1.7.02
[ 10091
]
Key
LEOPARD-149
CORE-94
Project
i2b2
[ 10000
]
i2b2 Core Project
[ 10034
]
Affects Version/s
1.7.01
[ 10154
]
Affects Version/s
1.7.01
[ 10090
]
Janice Donahoe
made changes -
06/Jun/14 11:27 AM
Status
Ready to Test
[ 10001
]
Testing
[ 10002
]
Janice Donahoe
made changes -
09/Jun/14 10:28 AM
Build Number/s (Testing)
1.7.02.0005
Testing Notes
Tested with the latest build and it appears to be working correctly. Tested the xml message using Advanced Rest Client in google chrome. The PDO was returned without any errors.
Status
Testing
[ 10002
]
Testing
[ 10002
]
Janice Donahoe
made changes -
09/Jun/14 10:28 AM
Build Number (Fixed)
1.7.02.0005
Resolution
Fixed
[ 1
]
Status
Testing
[ 10002
]
Resolved
[ 5
]
Janice Donahoe
made changes -
01/Jul/14 11:38 AM
Status
Resolved
[ 5
]
Closed
[ 6
]
{"report":{"fcp":4176.100000000093,"ttfb":1015.5,"pageVisibility":"visible","entityId":10247,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":16,"apdex":0,"journeyId":"e39f9ce0-dc04-460d-a6f6-59123bf0d9f6","navigationType":0,"readyForUser":4260.600000000093,"redirectCount":0,"resourceLoadedEnd":4525.900000000023,"resourceLoadedStart":1035,"resourceTiming":[{"duration":210.20000000006985,"initiatorType":"link","name":"https://community.i2b2.org/jira/s/7fd763ecdf5ed1f47fc4d22fa8382e97-CDN/4x9nqn/820011/16zrvj4/49fa3aa3d35a2cc689cbf274e66cc41a/_/download/contextbatch/css/_super/batch.css","startTime":1035,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1035,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1245.2000000000698,"responseStart":0,"secureConnectionStart":0},{"duration":210.5,"initiatorType":"link","name":"https://community.i2b2.org/jira/s/898b8076c5e82f53cd816ca393e45a56-CDN/4x9nqn/820011/16zrvj4/f614b50eeb842ebd1ea7ab2903699907/_/download/contextbatch/css/project.issue.navigator,jira.view.issue,jira.global,atl.general,-_super/batch.css?jira.create.linked.issue=true&richediton=true","startTime":1035.4000000000233,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1035.4000000000233,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1245.9000000000233,"responseStart":0,"secureConnectionStart":0},{"duration":2163.29999999993,"initiatorType":"script","name":"https://community.i2b2.org/jira/s/4c9c503fe98f210445831b0d7b0cdc33-CDN/4x9nqn/820011/16zrvj4/49fa3aa3d35a2cc689cbf274e66cc41a/_/download/contextbatch/js/_super/batch.js?locale=en-US","startTime":1035.6000000000931,"connectEnd":3117.9000000000233,"connectStart":2534.100000000093,"domainLookupEnd":1035.6000000000931,"domainLookupStart":1035.6000000000931,"fetchStart":1035.6000000000931,"redirectEnd":0,"redirectStart":0,"requestStart":3117.9000000000233,"responseEnd":3198.9000000000233,"responseStart":3141.20000000007,"secureConnectionStart":3102.20000000007},{"duration":2450.29999999993,"initiatorType":"script","name":"https://community.i2b2.org/jira/s/694e598c1ae48b0f96655173631cd247-CDN/4x9nqn/820011/16zrvj4/f614b50eeb842ebd1ea7ab2903699907/_/download/contextbatch/js/project.issue.navigator,jira.view.issue,jira.global,atl.general,-_super/batch.js?jira.create.linked.issue=true&locale=en-US&richediton=true","startTime":1036.1000000000931,"connectEnd":3405.3000000000466,"connectStart":2928,"domainLookupEnd":1036.1000000000931,"domainLookupStart":1036.1000000000931,"fetchStart":1036.1000000000931,"redirectEnd":0,"redirectStart":0,"requestStart":3405.4000000000233,"responseEnd":3486.4000000000233,"responseStart":3427.4000000000233,"secureConnectionStart":3389.4000000000233},{"duration":2400.1999999999534,"initiatorType":"script","name":"https://community.i2b2.org/jira/s/53f54e0ac3f00bb56b136b4d2fff2853-CDN/4x9nqn/820011/16zrvj4/aae1242f5fc81cc6a5bb8bc963ccda29/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en-US","startTime":1036.3000000000466,"connectEnd":3418.9000000000233,"connectStart":2946.100000000093,"domainLookupEnd":1036.3000000000466,"domainLookupStart":1036.3000000000466,"fetchStart":1036.3000000000466,"redirectEnd":0,"redirectStart":0,"requestStart":3419.3000000000466,"responseEnd":3436.5,"responseStart":3435.600000000093,"secureConnectionStart":3402.70000000007},{"duration":2464.9000000000233,"initiatorType":"script","name":"https://community.i2b2.org/jira/s/d41d8cd98f00b204e9800998ecf8427e-CDN/4x9nqn/820011/16zrvj4/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":1036.3000000000466,"connectEnd":3474.20000000007,"connectStart":2993.8000000000466,"domainLookupEnd":1036.3000000000466,"domainLookupStart":1036.3000000000466,"fetchStart":1036.3000000000466,"redirectEnd":0,"redirectStart":0,"requestStart":3474.3000000000466,"responseEnd":3501.20000000007,"responseStart":3498.20000000007,"secureConnectionStart":3455.20000000007},{"duration":2498.3000000000466,"initiatorType":"script","name":"https://community.i2b2.org/jira/s/d41d8cd98f00b204e9800998ecf8427e-CDN/4x9nqn/820011/16zrvj4/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":1036.5,"connectEnd":3517.4000000000233,"connectStart":3051.3000000000466,"domainLookupEnd":1036.5,"domainLookupStart":1036.5,"fetchStart":1036.5,"redirectEnd":0,"redirectStart":0,"requestStart":3517.5,"responseEnd":3534.8000000000466,"responseStart":3533.5,"secureConnectionStart":3500},{"duration":216.59999999997672,"initiatorType":"link","name":"https://community.i2b2.org/jira/s/30748292e4ca68be6947d7969829384b-CDN/4x9nqn/820011/16zrvj4/4f66da484ef7d95a2a604d3ab014374c/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":1036.7000000000698,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1036.7000000000698,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1253.3000000000466,"responseStart":0,"secureConnectionStart":0},{"duration":2595.29999999993,"initiatorType":"script","name":"https://community.i2b2.org/jira/rest/api/1.0/shortcuts/820011/766848d8ff8ea3676a80e44dfb51696a/shortcuts.js?context=issuenavigation&context=issueaction","startTime":1036.7000000000698,"connectEnd":3613,"connectStart":3180.4000000000233,"domainLookupEnd":1036.7000000000698,"domainLookupStart":1036.7000000000698,"fetchStart":1036.7000000000698,"redirectEnd":0,"redirectStart":0,"requestStart":3613.20000000007,"responseEnd":3632,"responseStart":3631.100000000093,"secureConnectionStart":3590.100000000093},{"duration":192,"initiatorType":"link","name":"https://community.i2b2.org/jira/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/4x9nqn/820011/16zrvj4/efa42a25652b26dfd802540c024826b3/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-jira.view.issue,-project.issue.navigator/batch.css?jira.create.linked.issue=true&richediton=true","startTime":1085.6000000000931,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1085.6000000000931,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1277.6000000000931,"responseStart":0,"secureConnectionStart":0},{"duration":3027.8000000000466,"initiatorType":"script","name":"https://community.i2b2.org/jira/s/8087506fefd02b4096991c90836b49f6-CDN/4x9nqn/820011/16zrvj4/efa42a25652b26dfd802540c024826b3/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-jira.view.issue,-project.issue.navigator/batch.js?jira.create.linked.issue=true&locale=en-US&richediton=true","startTime":1085.8000000000466,"connectEnd":4092.3000000000466,"connectStart":3843.600000000093,"domainLookupEnd":1085.8000000000466,"domainLookupStart":1085.8000000000466,"fetchStart":1085.8000000000466,"redirectEnd":0,"redirectStart":0,"requestStart":4092.4000000000233,"responseEnd":4113.600000000093,"responseStart":4112.20000000007,"secureConnectionStart":4074.9000000000233},{"duration":3404.9000000000233,"initiatorType":"script","name":"https://community.i2b2.org/jira/s/d41d8cd98f00b204e9800998ecf8427e-CDN/4x9nqn/820011/16zrvj4/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":1101.2000000000698,"connectEnd":4485.400000000023,"connectStart":4319.600000000093,"domainLookupEnd":1101.2000000000698,"domainLookupStart":1101.2000000000698,"fetchStart":1101.2000000000698,"redirectEnd":0,"redirectStart":0,"requestStart":4485.5,"responseEnd":4506.100000000093,"responseStart":4504,"secureConnectionStart":4468.600000000093},{"duration":3387.4000000000233,"initiatorType":"script","name":"https://community.i2b2.org/jira/s/d41d8cd98f00b204e9800998ecf8427e-CDN/4x9nqn/820011/16zrvj4/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":1138.5,"connectEnd":4499.300000000047,"connectStart":4328.100000000093,"domainLookupEnd":1138.5,"domainLookupStart":1138.5,"fetchStart":1138.5,"redirectEnd":0,"redirectStart":0,"requestStart":4505.20000000007,"responseEnd":4525.900000000023,"responseStart":4524.100000000093,"secureConnectionStart":4481.300000000047},{"duration":739.6999999999534,"initiatorType":"xmlhttprequest","name":"https://community.i2b2.org/jira/rest/webResources/1.0/resources","startTime":3381.100000000093,"connectEnd":4099,"connectStart":3854.8000000000466,"domainLookupEnd":3381.100000000093,"domainLookupStart":3381.100000000093,"fetchStart":3381.100000000093,"redirectEnd":0,"redirectStart":0,"requestStart":4099.5,"responseEnd":4120.800000000047,"responseStart":4119.900000000023,"secureConnectionStart":4082.3000000000466},{"duration":484,"initiatorType":"xmlhttprequest","name":"https://community.i2b2.org/jira/rest/webResources/1.0/resources","startTime":4177.400000000023,"connectEnd":4635.800000000047,"connectStart":4582.800000000047,"domainLookupEnd":4177.400000000023,"domainLookupStart":4177.400000000023,"fetchStart":4177.400000000023,"redirectEnd":0,"redirectStart":0,"requestStart":4635.900000000023,"responseEnd":4661.400000000023,"responseStart":4660.900000000023,"secureConnectionStart":4620.400000000023}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":178,"connectEnd":930,"secureConnectionStart":911,"requestStart":930,"responseStart":1016,"responseEnd":1138,"domLoading":1023,"domInteractive":4585,"domContentLoadedEventStart":4585,"domContentLoadedEventEnd":4652,"domComplete":5433,"loadEventStart":5433,"loadEventEnd":5434,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":4528},{"name":"bigPipe.sidebar-id.end","time":4529},{"name":"bigPipe.activity-panel-pipe-id.start","time":4529.100000000093},{"name":"bigPipe.activity-panel-pipe-id.end","time":4535},{"name":"activityTabFullyLoaded","time":4677}],"measures":[],"correlationId":"c698f22aa6522a","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":191,"dbReadsTimeInMs":25,"dbConnsTimeInMs":33,"applicationHash":"0629dd8d260e3954ece49053e565d01dabe11609","experiments":[]}}